HiveBrain v1.2.0
Get Started
← Back to all entries
patterncsharpMinor

Streamline code for checking if a directory exists and saving a file

Submitted by: @import:stackexchange-codereview··
0
Viewed 0 times
directoryfilecheckingandstreamlineforexistscodesaving

Problem

I hate this code. What is the slickest way to write the following:

MyFile = f;
SaveFolder = Server.MapPath("\\") + "returns\\";
if(!System.IO.Directory.Exists(SaveFolder) )
{
    System.IO.Directory.CreateDirectory(SaveFolder);
}
MyFile.SaveAs(SaveFolder + "2011" + "000-00-0000" + ".xlsx");

Solution

Since CreateDirectory does nothing if a directory already exists, you can do this:

MyFile = f;
SaveFolder = Path.Combine(Server.MapPath("\\"), "returns");
System.IO.Directory.CreateDirectory(SaveFolder);
MyFile.SaveAs(SaveFolder, "2011000-00-0000.xlsx");

Code Snippets

MyFile = f;
SaveFolder = Path.Combine(Server.MapPath("\\"), "returns");
System.IO.Directory.CreateDirectory(SaveFolder);
MyFile.SaveAs(SaveFolder, "2011000-00-0000.xlsx");

Context

StackExchange Code Review Q#2573, answer score: 8

Revisions (0)

No revisions yet.