Doubly linked list in C++

Please, review the code:

```
#include
using namespace std;

template
struct Node
{
Node(T data) : data(data), next(NULL), prev(NULL) {}
T data;
Node * next;
Node * prev;
};

template
class DoublyLinkedList
{
public:
DoublyLinkedList() : head(NULL), tail(NULL) {}
DoublyLinkedList(const DoublyLinkedList & dll);
~DoublyLinkedList();
void addNode(T data);
//void insertNodeBefore(int data, int before);
//void insertNodeAfter(int data, int after);
void deleteNode(T data);
template
friend std::ostream & operator & dll);
private:
Node * head;
Node * tail;
};

template
std::ostream & operator & dll)
{
Node * tmp = dll.head;
while (tmp)
{
os data next;
}

return os;
}

template
DoublyLinkedList::~DoublyLinkedList()
{
Node * tmp = NULL;
while (head)
{
tmp = head;
head = head->next;
delete tmp;
}
head = tail = NULL;
}

template
void DoublyLinkedList::addNode(T data)
{
Node * t = new Node(data);

Node * tmp = head;
if (tmp == NULL)
{
head = tail = t;
}
else
{
while (tmp->next != NULL)
{
tmp = tmp->next;
}

tmp->next = t;
t->prev = tail;

tail = t;
}
}

template
void DoublyLinkedList::deleteNode(T data)
{
Node * tmp = head;
while (tmp && tmp->data != data)
{
tmp = tmp->next;
}

if (tmp)
{
if (tmp->prev && tmp->next) // no change to head or tail
{
tmp->prev->next = tmp->next;
tmp->next->prev = tmp->prev;
}
else if (tmp->prev) // change to tail
{
tmp->prev->next = tmp->next;
tail = tmp->prev;
}
else if (tmp->next) // change to head
{
tmp->next->prev = tmp->prev;
head = tmp->next;
}

delete tmp;
}
}

template
DoublyLinkedList::DoublyLinkedList(const DoublyLinkedList & dll)
{
Node * tmp = dll.head;
while (tmp)
{
this->addNode(tmp->data);

-
Consider replacing Node with:

typedef Node node_t;

...

node_t node;

-
Consider making your implementation STL-enabled. If I were user of this class, the first thing I'd ask you is "how do I iterate over this list?". Doubly-linked lists are great when adding items in the middle, how do I do it? (it's about operations like insertBefore(), insertAfter()). How do I sort it? How do I check if item is on the list? How do I search using predicate?

-
Why do you call the method deleteNode if it's only argument is of type T? It's more to findNodeByValueAndDeleteIt(T).

-
What about assignment operator? You should either declare it private (if you don't support it), or implement it explicitly depending on semantics you want to support (deep copy (most likely what you want), reference, COW, etc):

YourList a; // do something with a

YourList b; // do something with b

a = b; // what is "a" here? what if I add nodes to a? will it affect b?

// imagine, scope ends here, dtor for b is called, everything's fine

// dtor for a is called - here you're going to crash, since

// both a and b were using the same memory and this memory is already

// free, since b's dtor has already been called at this point

-
For methods like void addNode(T data) - why do you pass data by value? Since you store item values by value, in either case you're going to call their copy-ctor. Copy-ctor requires const-reference, so you should consider replacing addNode with void addNode(T const& data).

-
using namespace std; - is it only for cout instead of std::cout in your main()?

Checked nothing from the "algorithmic" standpoint, C++ only.

StackExchange Code Review Q#4629, answer score: 10