HiveBrain v1.2.0
Get Started
← Back to all entries
patternphpMinor

Dispatcher for a JSON API without routes

Submitted by: @import:stackexchange-codereview··
0
Viewed 0 times
withoutroutesforjsonapidispatcher

Problem

I am using this code for a fast JSON API without routes.

Does this code contain any useless parts? Is the class loader efficient enough? Are there any better options? Is ReflectionMethod slow if used once?

= 2) {
  try {
    $controllerMethod = new ReflectionMethod( '\app\controller\\' .
                                                  $params[1], $params[2]
                                                );

    if ($paramsCount - 2 >= $controllerMethod->getNumberOfRequiredParameters()) {

      \ens\controller\Request::$lang =& $params[0];
      \ens\controller\Request::$data =& $_POST;

      $response = $controllerMethod->invokeArgs( null, array_splice($params, 3) );

    } else {
      $response = array('status' => 400);
    }

  } catch (ReflectionException $e) {
    $response = array('status' => 300);
  }

} else {
  $response = array('status' => 301);
}

if (!headers_sent()) {
  header('Content-Type: application/json');
}

echo json_encode($response);

Solution

IMHO, all the ini_set doesn't belong here, but in the php.ini, unless you can't edit it for some reasons…

If so, it belong in a bootstrap file, as for the constant definitions and the include


A bootstrap file usually starts by including those libraries that are necessary for the file itself to function correctly. This involves setting general directory and file paths, loading configuration files, etc.

This bootstrap file can also be very useful for many reasons described on the link i provided like:


[…] set up different application statuses such as Development, Production or Testing […]

An other thing:

IMHO, the test if (!headers_sent()) is pretty useless as is.

As you are returning JSON, you need to send this header('Content-Type: application/json'), so, if you can't for any reason, you should raise an error or an exception, not just doing nothing and echoing your JSON as if nothing happened…

Context

StackExchange Code Review Q#8262, answer score: 2

Revisions (0)

No revisions yet.