patternbashMinor
Bash script to swap out, edit host files
Viewed 0 times
scripteditswaphostfilesoutbash
Problem
This is my first useful bash script. It's meant to make it easy to switch between a "work" hosts file (that blocks sites like reddit.com, youtube.com, etc.) and my normal hosts file, and also to allow me to easily add/remove sites I want to block.
I'm not sure if I'm doing everything right or securely, so please feel free to pick at anything.
The
I'm not sure if I'm doing everything right or securely, so please feel free to pick at anything.
#!/bin/bash
usage()
{
cat > "$BLCK_FILE"
echo -e "\033[0;32madded\033[0m $host"
done
}
# todo: remove need for loop; do in one go
rm_host()
{
local hosts=("$@")
for host in "${hosts[@]:1}"; do
# overwrite host list file with a copy removing a certain host
awk -v host=$host 'NF==2 && $2!=host { print }' "$BLCK_FILE" > "$BLCK_TEMP"
mv "$BLCK_TEMP" "$BLCK_FILE"
echo -e "\033[0;31mremoved\033[0m $host"
done
}
check_root()
{
if [[ "`whoami`" != "root" ]]; then
echo "You don't have sufficient priviledges to run this script (try sudo.)"
exit 1
else
[[ -e $HOST_FILE ]] || { echo "Can't find or access host file."; exit 1; }
fi
}
start_block()
{
if [[ $IS_ACTIVE -ne 0 ]]; then
cp "$HOST_FILE" "$ORIG_FILE"
cat "$BLCK_FILE" >> "$HOST_FILE"
touch "$ACTIVE_FLAG"
echo "Block started."
else
echo "Already blocking."
fi
}
stop_block()
{
if [[ $IS_ACTIVE -eq 0 ]]; then
cp "$ORIG_FILE" "$HOST_FILE"
[[ -e $ACTIVE_FLAG ]] && rm "$ACTIVE_FLAG"
echo "Stopped blocking."
else
echo "Not blocking."
fi
}
case $1 in
'ls' | 'list')
awk 'NF == 2 { print $2 }; END { if (!NR) print "Empty" }' "$BLCK_FILE";;
'add')
[[ -z $2 ]] && { usage; exit 1; }
add_host $@;;
'rm' | 'remove')
[[ -z $2 ]] && { usage; exit 1; }
rm_host $@;;
'start')
check_root
start_block;;
'stop')
check_root
stop_block;;
*)
usage;;
esacThe
blocked_host file is appended to the `hoSolution
I think this is generally clean.
Style Points
use
Style Points
use
$() instead of ```, it's clearer and they can be nested.
E.g:
if [[ "$(whoami)" != "root" ]]; then
echo "You don't have sufficient priviledges to run this script (try sudo.)"
exit 1
Consider setting:
set -u #prevent unset variables
set -e #stop on an error
At the top of your script.
rm_host may benefit from rewriting using an inplace sed edit, rather than using awk to copy over the top of the old file.
Locks
Although unlikely, you may want to consider a lock to prevent races between add_host and rm_host. $ACTIVE_FLAG would make a good lock.
$VARDIR
It looks like you intend this script to be used at differing privileges level (e.g. root and non-root). This will change the $HOME env variable and consequently the $VARDIR env variable. Potentially {add,rm}_host may act on different files to {start,stop}_block. Note that this won't present itself if you only use sudo.
Reconsider what you want $VARDIR to be. On a a single user machine /var/` may be a good choice.Code Snippets
if [[ "$(whoami)" != "root" ]]; then
echo "You don't have sufficient priviledges to run this script (try sudo.)"
exit 1set -u #prevent unset variables
set -e #stop on an errorContext
StackExchange Code Review Q#10910, answer score: 4
Revisions (0)
No revisions yet.