HiveBrain v1.2.0
Get Started
← Back to all entries
patternjavascriptMinor

Cross-browser double form submit prevention

Submitted by: @import:stackexchange-codereview··
0
Viewed 0 times
crossbrowserdoublesubmitformprevention

Problem

We developed a potential solution for the double form submit prevention and we need some review on it. To be able to execute this code on asp.net we needed to add our function call directly into the onsubmit event of the form. This cannot be handled by jQuery because asp.net use a dopostback function and called form.submit(). If onsubmit attribute of the form is empty then it will not execute the code. We don't want to depend on a bloq-UI or disabled button actions.

This is our form tag



And this is our javascript that handles the double submit prevention:

//Double submit preventions
var _preventDoubleSubmit = false;

function preventDoubleSubmit(e) {

    if (_preventDoubleSubmit) {
        return cancelDoubleSubmit(e);
    }
    else {
        _preventDoubleSubmit = true;
        return true;
    }
}

function cancelDoubleSubmit(e) {
    if (!e) {
        e = window.event;
    }

    if (e.returnValue != undefined) {
        e.returnValue = false;
    }

    if (e.cancelBubble != undefined) {
        e.cancelBubble = true;
    }

    if (e.stopPropagation) {
        e.stopPropagation();
    }

    if (e.stopImmediatePropagation) {
        e.stopImmediatePropagation();
    }

    if (e.preventDefault) {
        e.preventDefault();
    }

    return false;
}
//END - Double submit prevention


Any review on this would be appreciated.

Solution

Can't you just overwrite the onsubmit handler with the first submission?

function preventDoubleSubmit(e) {
    e = e || window.event;
    var form = e.target || e.srcElement;

    form.onsubmit = function() {
        return false;
    };
}

Code Snippets

function preventDoubleSubmit(e) {
    e = e || window.event;
    var form = e.target || e.srcElement;

    form.onsubmit = function() {
        return false;
    };
}

Context

StackExchange Code Review Q#11874, answer score: 2

Revisions (0)

No revisions yet.