HiveBrain v1.2.0
Get Started
← Back to all entries
patternModerate

Capitalizing a string

Submitted by: @import:stackexchange-codereview··
0
Viewed 0 times
stringcapitalizingstackoverflow

Problem

I wrote the following function that takes a string and returns a new string with each word capitalized: first letter uppercase, following letters lower-cased.

It works, but I would be interested in seeing how a more sophisticated Haskell programmer would do this (if there is already a built-in, great, but still interested in an example implementation).

ghci> let capWord word = [toUpper $ head word] ++ (map toLower $ tail word)
ghci> let capitalize sentence = unwords $ map capWord $ words sentence
ghci> capitalize "the quick brown fox jUMPS OVER thE LaZY DOG"
"The Quick Brown Fox Jumps Over The Lazy Dog"

Solution

head and tail are partial functions, meaning that they are only defined for non-empty lists and will fail on empty ones. Because of this your capWord function is also partial and its strongly considered a bad practice to define such functions. In fact, the head and tail are also considered a bad heritage and in some alternative preludes it's been deliberately decided not to export such functions. So, firstly, you can redefine your function with pattern matching and make it total.

Secondly, you're introducing a redundant list for the first letter, instead you can prepend it using the : (pronounced "cons") operator.

Summing up we get the following definition:

capWord [] = []
capWord (h:t) = toUpper h : map toLower t


Alternatively (essentially the same):

capWord word = case word of
  [] -> []
  (h:t) -> toUpper h : map toLower t


The capitalize function is fine.

Code Snippets

capWord [] = []
capWord (h:t) = toUpper h : map toLower t
capWord word = case word of
  [] -> []
  (h:t) -> toUpper h : map toLower t

Context

StackExchange Code Review Q#23456, answer score: 11

Revisions (0)

No revisions yet.