patternjavascriptMinor
Single Page portfolio website
Viewed 0 times
websiteportfoliosinglepage
Problem
I have finished and launched my first website and would love some feedback/ideas for improvement. This is a single page website for the purpose of displaying my finished projects. I know that I have used a lot of
HTML:
```
Goode Development
Goode Development
Home
About
Portfolio
Contact
Kyle Goode
Full Stack Web Developer
About
The man...The myth...The legend
Kyle Goode is a young, caffeine dependent, Nashville local. He went to school in a small town just West of Nashville where he met and married his high school sweetheart. It is in that small town that Kyle's passion for technology began.Kyle has been amazed
with technology and programming even as a child,from trying to read code and quickly realizing he couldn't read the long "words" it was making to taking apart the family computers, much to the chagrin of his parents. Though his adult life has
been spent in the medical field, Kyle is excited to begin transitioning his hobby and passion to his profession.
Kyle Goode-the man in bullet points
Good Samaritan
Prefers puns intended
Especially gifted napper
Devoted to both programming and Game of Thrones
Codes for fun
Making History
Goes into survival mode if tickled
Anxiously awaiting you to connect with him for projects.
Skills
!important declarations to make things work properly. I have also used many media queries to have things be positioned where I want them. Any help is greatly appreciated. Thank you. Here is the websiteHTML:
```
Goode Development
Goode Development
Home
About
Portfolio
Contact
Kyle Goode
Full Stack Web Developer
About
The man...The myth...The legend
Kyle Goode is a young, caffeine dependent, Nashville local. He went to school in a small town just West of Nashville where he met and married his high school sweetheart. It is in that small town that Kyle's passion for technology began.Kyle has been amazed
with technology and programming even as a child,from trying to read code and quickly realizing he couldn't read the long "words" it was making to taking apart the family computers, much to the chagrin of his parents. Though his adult life has
been spent in the medical field, Kyle is excited to begin transitioning his hobby and passion to his profession.
Kyle Goode-the man in bullet points
Good Samaritan
Prefers puns intended
Especially gifted napper
Devoted to both programming and Game of Thrones
Codes for fun
Making History
Goes into survival mode if tickled
Anxiously awaiting you to connect with him for projects.
Skills
Solution
Some review items
-
You have 3 lines of comments, but none of them cover the least obvious code:
- Your photo is stretched, the original is not 510 by 510, does not look right at all
- You have a `
in your, that's wrong
- You have a
in your, that's wrong
- You have a
in your, that's Inceptional ;)
- I like your integrity
values, I learned something new
- On the whole, use this: https://html5.validator.nu/?doc=http%3A%2F%2Fgoodedevelopment.com%2F Your site should pass the validation flawlessly
- You probably want to cache $("#btnCollapse")
and$(this).find('.caption')
- You probably want to capture 250
in a single constant
- You are wrapping the last click handler in a $()
call but not the first 2, I would put them all in the wrapper
-
You have 3 lines of comments, but none of them cover the least obvious code:
$('a[href*="#"]:not([href="#"])').click(function() {
if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'') && location.hostname == this.hostname) {- I would probably replace that long if statement with a well document boolean-returning function
- As you know the use !important` is not considered good form, you should get rid of that.
Code Snippets
$('a[href*="#"]:not([href="#"])').click(function() {
if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'') && location.hostname == this.hostname) {Context
StackExchange Code Review Q#134082, answer score: 2
Revisions (0)
No revisions yet.