HiveBrain v1.2.0
Get Started
← Back to all entries
patternpythonMinor

Euler Project 14 (Longest Collatz Sequence)

Submitted by: @import:stackexchange-codereview··
0
Viewed 0 times
sequenceprojecteulerlongestcollatz

Problem

Project Euler 14 asks: Which starting number, under one million, produces the longest Collatz sequence?

I've been trying to optimize this solution to execute in less then 1s. Agenda for first 50 eulers. Currently it executes in 1,2s for me, so I guess that I want it to be 20% faster. Any tips or other methods?

from time import time

def rec_col(n, cache):
    if n in cache:
        return cache[n]
    x = (rec_col(n//2, cache) if n % 2 == 0 else rec_col(3*n+1, cache))+1
    cache[n] = x
    return x

def main():
    start = time()
    highest = 0
    ans = 1
    cache = {1: 1}
    for i in range(1, 10**6):
        temp = rec_col(i, cache)
        if temp > highest:
            ans = i
            highest = temp
    print("{0}\nTime {1:.4f} s".format(ans, time() - start))

if __name__ == '__main__':
    main()


This has the same preformance:

def rec_col(n, cache):
    cache[n] = (rec_col(n//2, cache) if n % 2 == 0 else rec_col(3*n+1, cache)) + 1 \
        if n not in cache else cache[n]
    return cache[n]

Solution

Using a 3.5 interpreter, things yielding "negative speed-up" included:

  • @functools.lru_cache(None) (mainly due to explicit base-case handling?)



  • substituting cache.get() and is not None for in and []



  • divmod(n, 2) instead of %2 and //2



  • "inlining the even case"



Negligible speed-up:

  • Binary operators instead of %2 and //2



  • Global cache instead of an explicit parameter



Slight speed-up:

  • rec_col((3*n+1) >> 1)+2



Of 1588206 cache entries, almost half are not used at all, not even one eighth twice, none more often.

Context

StackExchange Code Review Q#146883, answer score: 2

Revisions (0)

No revisions yet.