patterncppModerate
Battleship console game
Viewed 0 times
consolegamebattleship
Problem
This is a battleship console game I wrote in C++.
I really feel like I'm overcomplicating things. I feel like I overuse
#include
#include
#include
#include
#include
using namespace std;
int const ROW = 3;
int const COL = 3;
int subX, subY;
int guesses = 5;
int board[ROW][COL];
bool hasWon = false;
void winScreen()
{
cout > guessX;
if (guessX 2)
{
goodInput = false;
cin.clear();
cin.ignore(256, '\n');
cout > guessY;
if (guessY 2)
{
goodInput = false;
cin.clear();
cin.ignore(256, '\n');
cout 0);
//if lost
if (!hasWon)
cout << "Sorry, you lost. :(" << endl;
cout << "The sub was located at -" << subX << "," << subY << "-." << endl;
}I really feel like I'm overcomplicating things. I feel like I overuse
do whiles and I should try to use a catch and throw option or something a little more creative. Any suggestions would be appreciated.Solution
Using namespace std
Please review this post on why you should not use
Enums
You should use an enum to represent those values:
Now, instead of doing the confusing:
You can do:
Style
You have way too much vertical space in your program. You should really only use 1 empty line at a time.
Your bracing is inconsistent. Either always use them (preferred), or use them as little as possible.
Input
You never use the
Notice how similar the two sections in the following code is. Duplication everywhere.
You should join these into a single input function:
Then call it like:
This will also ensure the function gets good input back the first time
Your
Exceptions
Only use exceptions for exceptional behavior, not for control flow. Getting bad input is never exceptional--it is to be expected. Simple programs like this should almost never throw exceptions deliberately.
Please review this post on why you should not use
using namespace std: Why is “using namespace std” considered bad practice?Enums
//0 = empty
//1 = has guessed
//2 = subYou should use an enum to represent those values:
enum SquareType {
Empty = 0,
Guessed = 1,
Sub = 2
};Now, instead of doing the confusing:
if (board[x][y] == 0)
{
...
}
else if (board[x][y] == 1)
{
...
}
if (board[x][y] == 2)
{
...
}You can do:
if (board[x][y] == SquareType.Empty)
{
...
}
else if (board[x][y] == SquareType.Guessed)
{
...
}
if (board[x][y] == SquareType.Sub)
{
...
}Style
You have way too much vertical space in your program. You should really only use 1 empty line at a time.
Your bracing is inconsistent. Either always use them (preferred), or use them as little as possible.
Input
You never use the
do-while loop in playerGuess. If you carefully check the runtime, you break directly out of the loop every time you have bad input. That gives the loop a chance to continue if, and only if, you get two good inputs, but getting two good inputs automatically invalidates the continuation condition.Notice how similar the two sections in the following code is. Duplication everywhere.
//get X pick
cout > guessX;
if (guessX 2)
{
goodInput = false;
cin.clear();
cin.ignore(256, '\n');
cout > guessY;
if (guessY 2)
{
goodInput = false;
cin.clear();
cin.ignore(256, '\n');
cout << "Out of Range!" << endl;
//display grid again with X's on board where guessed
break;
}
else
{
goodInput = true;
}You should join these into a single input function:
int input(string prompt)
{
int guess = -1;
do {
cout > guess;
if (guess 2)
{
guess = -1;
cin.clear();
cin.ignore(256, '\n');
cout << "Out of Range!" << endl;
}
} while (guess == -1)
return guess;
}Then call it like:
//get X pick
guessX = input("X: ")
//get Y pick
guessY = input("Y: ")This will also ensure the function gets good input back the first time
input() returns.main()Your
main() function should only be the entrance to your program. You typically should not use main() to do work--create a function who's sole responsibility is doing that work. Right now, you gave main() two responsibilities--starting the program and running it.Exceptions
Only use exceptions for exceptional behavior, not for control flow. Getting bad input is never exceptional--it is to be expected. Simple programs like this should almost never throw exceptions deliberately.
Code Snippets
//0 = empty
//1 = has guessed
//2 = subenum SquareType {
Empty = 0,
Guessed = 1,
Sub = 2
};if (board[x][y] == 0)
{
...
}
else if (board[x][y] == 1)
{
...
}
if (board[x][y] == 2)
{
...
}if (board[x][y] == SquareType.Empty)
{
...
}
else if (board[x][y] == SquareType.Guessed)
{
...
}
if (board[x][y] == SquareType.Sub)
{
...
}//get X pick
cout << "X: ";
cin >> guessX;
if (guessX < 0 || guessX>2)
{
goodInput = false;
cin.clear();
cin.ignore(256, '\n');
cout << "Out of Range!" << endl;
//display grid again with X's on board where guessed
break;
}
else
{
goodInput = true;
}
//get Y pick
cout << "Y: ";
cin >> guessY;
if (guessY < 0 || guessY>2)
{
goodInput = false;
cin.clear();
cin.ignore(256, '\n');
cout << "Out of Range!" << endl;
//display grid again with X's on board where guessed
break;
}
else
{
goodInput = true;
}Context
StackExchange Code Review Q#149224, answer score: 17
Revisions (0)
No revisions yet.